Support <hr>-in-<select> #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per whatwg/html#9124. Tests from WebKit/WebKit#12407.
5 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 2, 2023
This is a long-standing WebKit feature that regressed as part of the standardized HTML parser effort. This suggests bringing it back with optional semantics, but a mandatory HTML parser change. The HTML parser change is not expected to be significant for existing content or XSS. When the feature is correctly used it will also not hurt HTML parsers that have not yet incorporated the change. I.e., it should be fully backwards compatible. Tests: html5lib/html5lib-tests#167. Fixes #3410.
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
May 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=80686 rdar://107656886 Reviewed by Ryosuke Niwa. Revive support in the HTML parser for <hr>-in-<select>, thereby making an existing UI feature much more accessible to web developers. This reflects a recent change in the HTML Standard: whatwg/html#9124. * LayoutTests/html5lib/resources/webkit02.dat: These are being upstreamed via html5lib/html5lib-tests#167 and will then be incorporated into web-platform-tests. * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): Canonical link: https://commits.webkit.org/263624@main
|
@flavorjones do you want to push a fixup commit for the errors perhaps? |
|
@annevk Thanks for asking. I have to do some work on the gumbo parser to support #9124. I'll very likely get to it today, but if you'd like to merge this in the meantime I'm happy to submit a PR once I get there. |
|
That works too. I'll merge this then. |
flavorjones
added a commit
to flavorjones/html5lib-tests
that referenced
this pull request
May 3, 2023
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
May 3, 2023
Ms2ger
pushed a commit
that referenced
this pull request
May 3, 2023
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per whatwg/html#9124. Tests from WebKit/WebKit#12407.